Skip to content

Use f32::NAN as a missing value #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2023
Merged

Use f32::NAN as a missing value #8

merged 1 commit into from
Dec 28, 2023

Conversation

vbkaisetsu
Copy link

@vbkaisetsu vbkaisetsu commented Dec 28, 2023 •
edited
Loading

This branch changes the value of the missing argument from 0 to f32::NAN to match the default behavior of the Python bindings.
https://github.com/dmlc/xgboost/blob/a197899161fa70e681101de4232745fdfe737804/python-package/xgboost/core.py#L843

montanalow
montanalow approved these changes Dec 28, 2023
View reviewed changes
Copy link

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change IMO, although it'd be better to contribute upstream if possible, and update our fork.

@montanalow montanalow merged commit a5138a1 into postgresml:master Dec 28, 2023
@vbkaisetsu vbkaisetsu deleted the patch-1 branch December 29, 2023 02:03
@vbkaisetsu
Copy link
Author

submitted to upstream: davechallis#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montanalow montanalow montanalow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbkaisetsu @montanalow